Stable UNIX users: functionality #51200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
added
the
no-changelog
github-actions
bot
added
audit-log
rosstimothy
reviewed
Jan 24, 2025
rosstimothy
approved these changes
Jan 27, 2025
| return nil, trace.BadParameter("missing Emitter") | ||
| } | ||
| if c.Logger == nil { | ||
| return nil, trace.BadParameter("missing Logger") |
There was a problem hiding this comment.
Use slog.Default instead of failing?
There was a problem hiding this comment.
In the one place where we call this in real code we have access to the logger from the auth server - we can let the caller specify a default or noop logger, IMO.
espadolini
force-pushed
the
espadolini/stable-unix-user
branch
from
58c1a94 to
8fe2aba
Compare
|
@eriktate friendly ping |
eriktate
approved these changes
Jan 29, 2025
espadolini
added a commit
that referenced
this pull request
Jan 29, 2025
* wiring the API client through * tctl stable-unix-users ls * stable UID fallback for Teleport SSHD * stable_unix_user.create event * fix-license * Require and test audit log message * Add stable_unix_user_config to fileconf * Avoid saying "fallback UID" in logs * Avoid saying "fallback UID" in error messages * Avoid racing writes in the mock emitter * pnpm lint-fix * fix lib/auth tests that broken during rebase
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the use of fallback UIDs for host user creation in the Teleport SSHd and a
tctlsubcommand (tctl stable-unix-users ls) to list the persisted usernames and their UIDs. This PR also adds an audit log event to the API, emitted when a new username is written, and support for configuring the feature in the auth server's config file.Related RFD: #50414
Part of #50292